From: petit87 <west12capri12@gmail.com>
Date: Sat, 26 Feb 2022 21:46:32 +0000 (-0500)
Subject: Fix repr for MySQL SET, generic Enum
X-Git-Tag: rel_2_0_0b1~450^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a926dea6b78c91b627f0f0b86cdc6a9279872e99;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Fix repr for MySQL SET, generic Enum

Fixed issues in :class:`_mysql.SET` datatype as well as :class:`.Enum`
where the ``__repr__()`` method would not render all optional parameters in
the string output, impacting the use of these types in Alembic
autogenerate. Pull request for MySQL courtesy Yuki Nishimine.

Fixes: #7720
Fixes: #7789
Closes: #7772
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/7772
Pull-request-sha: d58845479f497f6b2e12d7df2e9eb2d6ac22109b
Co-authored-by: Mike Bayer <mike_mp@zzzcomputing.com>

Change-Id: Idcec23eab4258511d9f32f4e3d78e511ea6021f1
---

diff --git a/doc/build/changelog/unreleased_14/7720_7789.rst b/doc/build/changelog/unreleased_14/7720_7789.rst
new file mode 100644
index 0000000000..5c1026ef5f
--- /dev/null
+++ b/doc/build/changelog/unreleased_14/7720_7789.rst
@@ -0,0 +1,9 @@
+.. change::
+    :tags: bug, sql, mysql
+    :tickets: 7720, 7789
+
+    Fixed issues in :class:`_mysql.SET` datatype as well as :class:`.Enum`
+    where the ``__repr__()`` method would not render all optional parameters in
+    the string output, impacting the use of these types in Alembic
+    autogenerate. Pull request for MySQL courtesy Yuki Nishimine.
+
diff --git a/lib/sqlalchemy/dialects/mysql/enumerated.py b/lib/sqlalchemy/dialects/mysql/enumerated.py
index 8758588715..c35b7226d8 100644
--- a/lib/sqlalchemy/dialects/mysql/enumerated.py
+++ b/lib/sqlalchemy/dialects/mysql/enumerated.py
@@ -233,3 +233,12 @@ class SET(_StringType):
     def adapt(self, impltype, **kw):
         kw["retrieve_as_bitwise"] = self.retrieve_as_bitwise
         return util.constructor_copy(self, impltype, *self.values, **kw)
+
+    def __repr__(self):
+        return util.generic_repr(
+            self,
+            to_inspect=[SET, _StringType],
+            additional_kw=[
+                ("retrieve_as_bitwise", False),
+            ],
+        )
diff --git a/lib/sqlalchemy/sql/sqltypes.py b/lib/sqlalchemy/sql/sqltypes.py
index d022a24caa..3794fd8f79 100644
--- a/lib/sqlalchemy/sql/sqltypes.py
+++ b/lib/sqlalchemy/sql/sqltypes.py
@@ -1453,7 +1453,10 @@ class Enum(Emulated, String, TypeEngine[Union[str, enum.Enum]], SchemaType):
     def __repr__(self):
         return util.generic_repr(
             self,
-            additional_kw=[("native_enum", True)],
+            additional_kw=[
+                ("native_enum", True),
+                ("create_constraint", False),
+            ],
             to_inspect=[Enum, SchemaType],
         )
 
diff --git a/test/dialect/mysql/test_types.py b/test/dialect/mysql/test_types.py
index 3d26e1d07f..de93a97a4a 100644
--- a/test/dialect/mysql/test_types.py
+++ b/test/dialect/mysql/test_types.py
@@ -1310,6 +1310,24 @@ class EnumSetTest(
             [("", ""), ("", ""), ("two", "two"), (None, None)],
         )
 
+    @testing.combinations(
+        (
+            [""],
+            {"retrieve_as_bitwise": True},
+            "SET('', retrieve_as_bitwise=True)",
+        ),
+        (["a"], {}, "SET('a')"),
+        (["a", "b", "c"], {}, "SET('a', 'b', 'c')"),
+        (
+            ["a", "b", "c"],
+            {"collation": "utf8_bin"},
+            "SET('a', 'b', 'c', collation='utf8_bin')",
+        ),
+        argnames="value,kw,expected",
+    )
+    def test_set_repr(self, value, kw, expected):
+        eq_(repr(mysql.SET(*value, **kw)), expected)
+
 
 def colspec(c):
     return testing.db.dialect.ddl_compiler(
diff --git a/test/sql/test_types.py b/test/sql/test_types.py
index 4e1048cb69..58dfa4dd8a 100644
--- a/test/sql/test_types.py
+++ b/test/sql/test_types.py
@@ -2479,6 +2479,13 @@ class EnumTest(AssertsCompiledSQL, fixtures.TablesTest):
             "inherit_schema=True, native_enum=False)",
         )
 
+    def test_repr_two(self):
+        e = Enum("x", "y", name="somename", create_constraint=True)
+        eq_(
+            repr(e),
+            "Enum('x', 'y', name='somename', create_constraint=True)",
+        )
+
     def test_length_native(self):
         e = Enum("x", "y", "long", length=42)