From: Francis Dupont <fdupont@isc.org>
Date: Sun, 1 Nov 2015 07:10:16 +0000 (+0100)
Subject: [hackathon94] Better/simpler fix
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a92fb8cde816cc6e29c6ec53f8a1f795a1c6f21e;p=thirdparty%2Fkea.git

[hackathon94] Better/simpler fix
---

diff --git a/src/bin/dhcp4/tests/config_parser_unittest.cc b/src/bin/dhcp4/tests/config_parser_unittest.cc
index a495d12a57..18123e380f 100644
--- a/src/bin/dhcp4/tests/config_parser_unittest.cc
+++ b/src/bin/dhcp4/tests/config_parser_unittest.cc
@@ -4014,13 +4014,9 @@ TEST_F(Dhcp4ParserTest, 4o6subnetInterfaceId) {
     ASSERT_TRUE(ifaceid);
 
     vector<uint8_t> data = ifaceid->getData();
-    const char *exp_data = "vlan123";
-    // Let's convert vlan123 to vector<uint8_t> format.
-    // We need to skip the last \0 byte, thuse sizeof() - 1.
-    vector<uint8_t> exp(exp_data, exp_data + sizeof(*exp_data) - 1);
-
-    EXPECT_TRUE(exp == data);
+    EXPECT_EQ(7, data.size());
+    const char *exp = "vlan123";
+    EXPECT_EQ(0, memcmp(&data[0], exp, data.size()));
 }
 
-
 }