From: Simon McVittie <smcv@collabora.com>
Date: Wed, 25 Sep 2024 13:38:31 +0000 (+0100)
Subject: dbus-spam: Ensure that payload_len is always initialized
X-Git-Tag: dbus-1.15.10~2^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a936c7c4d534f2601d0a1d86015c0217dbae43a9;p=thirdparty%2Fdbus.git

dbus-spam: Ensure that payload_len is always initialized

A command like `dbus-test-tool spam --payload=abcde --bytes` could
previously have left the length uninitialized.

Detected by compiling with gcc 14.

Signed-off-by: Simon McVittie <smcv@collabora.com>
---

diff --git a/tools/dbus-spam.c b/tools/dbus-spam.c
index 7c0a7168d..43f260ba3 100644
--- a/tools/dbus-spam.c
+++ b/tools/dbus-spam.c
@@ -164,7 +164,7 @@ dbus_test_tool_spam (int argc, char **argv)
   int queue_len = 1;
   const char *payload = NULL;
   char *payload_buf = NULL;
-  size_t payload_len;
+  size_t payload_len = 0;
   int payload_type = DBUS_TYPE_STRING;
   DBusMessage *template = NULL;
   dbus_bool_t flood = FALSE;
@@ -217,6 +217,7 @@ dbus_test_tool_spam (int argc, char **argv)
       else if (strstr (arg, "--payload=") == arg)
         {
           payload = arg + strlen ("--payload=");
+          payload_len = strlen (payload);
         }
       else if (strcmp (arg, "--stdin") == 0)
         {