From: Daniel P. Berrange <berrange@redhat.com>
Date: Wed, 25 Sep 2013 14:36:39 +0000 (+0100)
Subject: Avoid crash on OOM in virnetmessagetest
X-Git-Tag: v1.1.3-rc1~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a93eb09a971f191e0ee91a8611ac976d71077987;p=thirdparty%2Flibvirt.git

Avoid crash on OOM in virnetmessagetest

The virnetmessagetest code did not check for failure to
allocate the message object. This lead to a crash on OOM
in the test suite.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/tests/virnetmessagetest.c b/tests/virnetmessagetest.c
index 1aa4c25a66..3c9bead5d3 100644
--- a/tests/virnetmessagetest.c
+++ b/tests/virnetmessagetest.c
@@ -327,6 +327,9 @@ static int testMessagePayloadDecode(const void *args ATTRIBUTE_UNUSED)
     };
     int ret = -1;
 
+    if (!msg)
+        return -1;
+
     msg->bufferLength = 4;
     if (VIR_ALLOC_N(msg->buffer, msg->bufferLength) < 0)
         goto cleanup;
@@ -476,6 +479,9 @@ static int testMessagePayloadStreamEncode(const void *args ATTRIBUTE_UNUSED)
     };
     int ret = -1;
 
+    if (!msg)
+        return -1;
+
     msg->header.prog = 0x11223344;
     msg->header.vers = 0x01;
     msg->header.proc = 0x666;