From: bbaetz%student.usyd.edu.au <>
Date: Sat, 29 Jun 2002 08:59:21 +0000 (+0000)
Subject: Bug 152138 - 2.14.2 breaks sorting on more than one field
X-Git-Tag: bugzilla-2.14.3~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a940d40e3ce69718b2216698597ab020e909e5e2;p=thirdparty%2Fbugzilla.git

Bug 152138 - 2.14.2 breaks sorting on more than one field
r=timeless, preed
---

diff --git a/buglist.cgi b/buglist.cgi
index d6e98fdd1c..4e34ae5115 100755
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -1072,7 +1072,7 @@ if (defined $::FORM{'order'} && $::FORM{'order'} ne "") {
             # A custom list of columns.  Make sure each column is valid.
             foreach my $fragment (split(/,/, $::FORM{'order'})) {
                 my $ident_iregexp = "[a-z_][0-9a-z_]*";
-                if (trim($fragment) !~ /^${ident_iregexp}\.${ident_iregexp}(\s+(asc|desc))?$/i) {
+                if ($fragment !~ /^\s*${ident_iregexp}\.${ident_iregexp}(\s+(asc|desc))?\s*$/i) {
                     my $qfragment = html_quote($fragment);
                     my $error = "The custom sort order you specified in your "
                               . "form submission contains an invalid column "
@@ -1095,7 +1095,7 @@ if (defined $::FORM{'order'} && $::FORM{'order'} ne "") {
             last ORDER;
         };
         /Assign/ && do {
-            $::FORM{'order'} = "map_assigned_to.login_name, bugs.bug_status, priority, bugs.bug_id";
+            $::FORM{'order'} = "map_assigned_to.login_name, bugs.bug_status, bugs.priority, bugs.bug_id";
             last ORDER;
         };
         # DEFAULT