From: Remi Gacogne Date: Wed, 12 Nov 2025 10:46:09 +0000 (+0100) Subject: dnsdist: Fix a typo when a Yaml-originated selector name does not exist X-Git-Tag: rec-5.4.0-alpha1~91^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a94767dd8f349490ed2587055ea7e590efd79368;p=thirdparty%2Fpdns.git dnsdist: Fix a typo when a Yaml-originated selector name does not exist Signed-off-by: Remi Gacogne --- diff --git a/pdns/dnsdistdist/dnsdist-configuration-yaml.cc b/pdns/dnsdistdist/dnsdist-configuration-yaml.cc index 774d360312..da4503ad65 100644 --- a/pdns/dnsdistdist/dnsdist-configuration-yaml.cc +++ b/pdns/dnsdistdist/dnsdist-configuration-yaml.cc @@ -1922,7 +1922,7 @@ std::shared_ptr getByNameSelector(const ByNameSelectorConfiguration { auto ptr = dnsdist::configuration::yaml::getRegisteredTypeByName(config.selector_name); if (!ptr) { - throw std::runtime_error("Unable find a selector named " + std::string(config.selector_name)); + throw std::runtime_error("Unable to find a selector named " + std::string(config.selector_name)); } return ptr; } diff --git a/regression-tests.dnsdist/test_Yaml.py b/regression-tests.dnsdist/test_Yaml.py index 86662ebd1b..52b3239f56 100644 --- a/regression-tests.dnsdist/test_Yaml.py +++ b/regression-tests.dnsdist/test_Yaml.py @@ -566,7 +566,7 @@ query_rules: cls.startDNSDist() except AssertionError as err: failed = True - expected = "dnsdist --check-config failed (1): b'Error while parsing YAML file configs/dnsdist_TestYamlUnknownSelectorName.yml: Unable find a selector named is-tcp\\n'" + expected = "dnsdist --check-config failed (1): b'Error while parsing YAML file configs/dnsdist_TestYamlUnknownSelectorName.yml: Unable to find a selector named is-tcp\\n'" if str(err) != expected: raise AssertionError("DNSdist should not start with an unknown selector name: %s" % (err)) if not failed: