From: bugreport%peshkin.net <>
Date: Sat, 10 Jul 2004 14:44:12 +0000 (+0000)
Subject: Bug 234855: Show only products enterable by current user in edit-multiple
X-Git-Tag: bugzilla-2.18rc1~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a95006629e25bdce2016c4544318df380c91f0fd;p=thirdparty%2Fbugzilla.git

Bug 234855: Show only products enterable by current user in edit-multiple
patch by kiko
r=joel,justdave
a=justdave
---

diff --git a/buglist.cgi b/buglist.cgi
index caf0943128..28993cbec2 100755
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -875,7 +875,8 @@ if ($dotweak) {
     $vars->{'dotweak'} = 1;
     $vars->{'use_keywords'} = 1 if @::legal_keywords;
 
-    $vars->{'products'} = \@::legal_product;
+    my @enterable_products = GetEnterableProducts();
+    $vars->{'products'} = \@enterable_products;
     $vars->{'platforms'} = \@::legal_platform;
     $vars->{'priorities'} = \@::legal_priority;
     $vars->{'severities'} = \@::legal_severity;
diff --git a/globals.pl b/globals.pl
index a2172a998e..6632833abd 100644
--- a/globals.pl
+++ b/globals.pl
@@ -516,6 +516,17 @@ sub CanEnterProduct {
     return ($ret);
 }
 
+sub GetEnterableProducts {
+    my @products;
+    # XXX rewrite into pure SQL instead of relying on legal_products?
+    foreach my $p (@::legal_product) {
+        if (CanEnterProduct($p)) {
+            push @products, $p;
+        }
+    }
+    return (@products);
+}
+
 #
 # This function returns an alphabetical list of product names to which
 # the user can enter bugs.  If the $by_id parameter is true, also retrieves IDs