From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 30 Nov 2021 10:33:10 +0000 (+0100)
Subject: virDomainNetDefParseXML: Automatically free GHashTable
X-Git-Tag: v8.0.0-rc1~430
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a977173aa612368ef55349ec77c74d0b36aaffa7;p=thirdparty%2Flibvirt.git

virDomainNetDefParseXML: Automatically free GHashTable

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 5cd1bede02..14aeda4573 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -10221,7 +10221,7 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt,
     xmlNodePtr vlan_node = NULL;
     xmlNodePtr bandwidth_node = NULL;
     xmlNodePtr tmpNode;
-    GHashTable *filterparams = NULL;
+    g_autoptr(GHashTable) filterparams = NULL;
     virDomainActualNetDef *actual = NULL;
     VIR_XPATH_NODE_AUTORESTORE(ctxt)
     virDomainChrSourceReconnectDef reconnect = {0};
@@ -10408,7 +10408,6 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt,
 
     if ((filterref_node = virXPathNode("./filterref", ctxt))) {
         filter = virXMLPropString(filterref_node, "filter");
-        virHashFree(filterparams);
         filterparams = virNWFilterParseParamAttributes(filterref_node);
     }
 
@@ -10937,7 +10936,6 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt,
 
  cleanup:
     virDomainActualNetDefFree(actual);
-    virHashFree(filterparams);
     return def;
 
  error: