From: Daniel Stenberg <daniel@haxx.se>
Date: Thu, 2 Oct 2014 21:01:45 +0000 (+0200)
Subject: imap_perform_authentication: fix memory leak
X-Git-Tag: curl-7_39_0~197
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a9beeeeeeac018157412e4510342554a48df54f4;p=thirdparty%2Fcurl.git

imap_perform_authentication: fix memory leak

Coverity CID 1215296. There's a potential risk for a memory leak in
here, and moving the free call to be unconditional seems like a cheap
price to remove the risk.
---

diff --git a/lib/imap.c b/lib/imap.c
index 9fc472866d..ee1bad2952 100644
--- a/lib/imap.c
+++ b/lib/imap.c
@@ -634,8 +634,6 @@ static CURLcode imap_perform_authentication(struct connectdata *conn)
     if(mech && (imapc->preftype & IMAP_TYPE_SASL)) {
       /* Perform SASL based authentication */
       result = imap_perform_authenticate(conn, mech, initresp, state1, state2);
-
-      Curl_safefree(initresp);
     }
     else if((!imapc->login_disabled) &&
             (imapc->preftype & IMAP_TYPE_CLEARTEXT))
@@ -648,6 +646,8 @@ static CURLcode imap_perform_authentication(struct connectdata *conn)
     }
   }
 
+  Curl_safefree(initresp);
+
   return result;
 }