From: Joe Guo <joeg@catalyst.net.nz>
Date: Tue, 3 Jul 2018 23:03:42 +0000 (+1200)
Subject: smbd/msdfs: add null check for session_info.unix_info
X-Git-Tag: tdb-1.3.16~25
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a9c6ec66bc52d288dcd9f26371e3639345ffe8b5;p=thirdparty%2Fsamba.git

smbd/msdfs: add null check for session_info.unix_info

When a session_info passed down to here, the unix_info could be NULL.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13521

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c
index bac9d8f6bf6..f0ec6b84892 100644
--- a/source3/smbd/msdfs.c
+++ b/source3/smbd/msdfs.c
@@ -307,7 +307,12 @@ static NTSTATUS create_conn_struct_as_root(TALLOC_CTX *ctx,
 			TALLOC_FREE(conn);
 			return NT_STATUS_NO_MEMORY;
 		}
-		vfs_user = conn->session_info->unix_info->unix_name;
+		/* unix_info could be NULL in session_info */
+		if (conn->session_info->unix_info != NULL) {
+			vfs_user = conn->session_info->unix_info->unix_name;
+		} else {
+			vfs_user = get_current_username();
+		}
 	} else {
 		/* use current authenticated user in absence of session_info */
 		vfs_user = get_current_username();