From: jocuri%softhome.net <>
Date: Fri, 27 Feb 2004 19:18:45 +0000 (+0000)
Subject: Patch for bug 192247: make Bugzilla quips truly random; code by Bill McGonigle <bill... 
X-Git-Tag: bugzilla-2.17.7~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a9f2317f92af527b28fe648777bacf164ac029f9;p=thirdparty%2Fbugzilla.git

Patch for bug 192247: make Bugzilla quips truly random; code by Bill McGonigle <bill+mozilla@zettabyte.net>; r=bbaetz, justdave, a=justdave.
---

diff --git a/buglist.cgi b/buglist.cgi
index ab7373e06d..d1a3c665ba 100755
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -199,7 +199,13 @@ sub GetQuip {
 
     my $quip;
 
-    SendSQL("SELECT quip FROM quips WHERE approved = 1 ORDER BY RAND() LIMIT 1");
+    # COUNT is quick because it is cached for MySQL. We may want to revisit
+    # this when we support other databases.
+
+    SendSQL("SELECT COUNT(quip) FROM quips WHERE approved = 1");
+    my $count = FetchOneColumn();
+    my $random = int(rand($count));
+    SendSQL("SELECT quip FROM quips WHERE approved = 1 LIMIT $random,1");
 
     if (MoreSQLData()) {
         ($quip) = FetchSQLData();