From: Mark Andrews Date: Wed, 5 Feb 2020 04:55:08 +0000 (+1100) Subject: 'indentctx' is always defined. Just use it. X-Git-Tag: v9.16.0~29^2~15 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aa101260d964db5552c6107254a545ba8d583bbb;p=thirdparty%2Fbind9.git 'indentctx' is always defined. Just use it. 402 ctx->serve_stale_ttl = 0; notnull: At condition indentctx, the value of indentctx cannot be NULL. dead_error_condition: The condition indentctx must be true. CID 1456147 (#1 of 1): Logically dead code (DEADCODE) dead_error_line: Execution cannot reach the expression default_indent inside this statement: ctx->indent = (indentctx ? .... 403 ctx->indent = indentctx ? *indentctx : default_indent; --- diff --git a/lib/dns/masterdump.c b/lib/dns/masterdump.c index 662652bf8a6..f3f02d049b0 100644 --- a/lib/dns/masterdump.c +++ b/lib/dns/masterdump.c @@ -400,7 +400,7 @@ totext_ctx_init(const dns_master_style_t *style, const dns_indent_t *indentctx, ctx->current_ttl = 0; ctx->current_ttl_valid = false; ctx->serve_stale_ttl = 0; - ctx->indent = indentctx ? *indentctx : default_indent; + ctx->indent = *indentctx; return (ISC_R_SUCCESS); }