From: Kohei Yoshino <kohei.yoshino@gmail.com>
Date: Fri, 1 Dec 2017 03:42:14 +0000 (-0500)
Subject: Bug 1420300 - Move bug tagging tool from global footer to bug footer
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aa3f0331fb7e0b97201afb806b777a03c9f2fca2;p=thirdparty%2Fbugzilla.git

Bug 1420300 - Move bug tagging tool from global footer to bug footer
---

diff --git a/docs/en/rst/using/finding.rst b/docs/en/rst/using/finding.rst
index a8e18eef2..44d4003dc 100644
--- a/docs/en/rst/using/finding.rst
+++ b/docs/en/rst/using/finding.rst
@@ -257,3 +257,19 @@ Remember Search As:
     You can give a search a name and remember it; a link will appear
     in your page footer giving you quick access to run it again later.
 
+Individual Bug Lists
+====================
+
+You can add and remove tags from individual bugs, which let you find and manage
+bugs more easily. Tags are per-user and so are only visible and editable by the
+user who created them. You can then run queries using tags as a criteria, either
+by using the Advanced Search form, or simply by typing "tag:my_tag_name" in the
+QuickSearch box at the top (or bottom) of the page. Tags can also be displayed
+in bug lists.
+
+This feature is useful when you want to keep track of several bugs, but for
+different reasons. Instead of adding yourself to the CC list of all these bugs
+and mixing all these reasons, you can now store these bugs in separate lists,
+e.g. “Keep in mind”, “Interesting bugs”, or “Triage”. One big advantage of this
+way to manage bugs is that you can easily add or remove tags from bugs one by
+one.
diff --git a/extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl b/extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl
index 365370d50..211d673ca 100644
--- a/extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl
+++ b/extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl
@@ -1385,6 +1385,10 @@
   </form>
 [% END %]
 
+[%# === individual bugs addition === %]
+
+[% PROCESS "bug/tagging.html.tmpl" %]
+
 [%# === blocks === %]
 
 [% BLOCK new_comment %]
diff --git a/template/en/default/bug/navigate.html.tmpl b/template/en/default/bug/navigate.html.tmpl
index f0c924160..027e3fcf9 100644
--- a/template/en/default/bug/navigate.html.tmpl
+++ b/template/en/default/bug/navigate.html.tmpl
@@ -41,6 +41,8 @@
     [% Hook.process("links") %]
     <li>&nbsp;-&nbsp;<a href="#">Top of page </a></li>
   </ul>
+  [% PROCESS "bug/tagging.html.tmpl" %]
+  <hr>
 [% END %]
 
 [% SET my_search = user.recent_search_for(bug) %]
diff --git a/template/en/default/global/per-bug-queries.html.tmpl b/template/en/default/bug/tagging.html.tmpl
similarity index 81%
rename from template/en/default/global/per-bug-queries.html.tmpl
rename to template/en/default/bug/tagging.html.tmpl
index b5c2431e1..88c113051 100644
--- a/template/en/default/global/per-bug-queries.html.tmpl
+++ b/template/en/default/bug/tagging.html.tmpl
@@ -14,13 +14,11 @@
   #%]
 
 [% IF user.id && user.settings.per_bug_queries.value == "on" %]
-  <li id="links-special">
-    <div class="label"></div>
-    <ul class="links"><li class="form">
       <form id="list_of_bugs" action="buglist.cgi" method="get">
         <input type="hidden" name="cmdtype" value="doit">
         <input type="hidden" name="remtype" value="asnamed">
         <input type="hidden" name="list_of_bugs" value="1">
+        <input type="hidden" name="bug_ids" value="[% bug.id FILTER none %]">
         <input type="hidden" name="token" value="[% issue_hash_token(['savedsearch']) FILTER html %]">
         <select id="lob_action" name="action" >
           <option value="add">Add</option>
@@ -30,7 +28,7 @@
         </select>
 
         [% IF Param('docs_urlbase') %]
-          <a href="[% docs_urlbase FILTER html %]query.html#individual-buglists">the named tag</a>
+          <a href="[% docs_urlbase FILTER html %]using/finding.html#individual-bug-lists">the named tag</a>
         [% ELSE %]
           the named tag
         [% END %]
@@ -48,11 +46,7 @@
                  size="20" maxlength="64" name="newqueryname">
         </span>
         <span id="lob_direction">to</span>
-        [%+ terms.bugs %]
-        <input type="text" name="bug_ids" size="12" maxlength="80"
-         [%- " value=\"$bugids\"" IF bugids %]>
-        <input type="submit" value="Commit" id="commit_list_of_bugs">
+        this [% terms.bug %]
+        <input type="submit" value="Save Tag" id="commit_list_of_bugs">
       </form>
-    </li></ul>
-  </li>
 [% END %]
diff --git a/template/en/default/filterexceptions.pl b/template/en/default/filterexceptions.pl
index 237dd7b46..39f064035 100644
--- a/template/en/default/filterexceptions.pl
+++ b/template/en/default/filterexceptions.pl
@@ -185,10 +185,6 @@
   'series.frequency * 2',
 ],
 
-'global/per-bug-queries.html.tmpl' => [
-  '" value=\"$bugids\"" IF bugids',
-],
-
 'global/select-menu.html.tmpl' => [
   'options',
   'size',
diff --git a/template/en/default/global/useful-links.html.tmpl b/template/en/default/global/useful-links.html.tmpl
index dd4fed424..467719028 100644
--- a/template/en/default/global/useful-links.html.tmpl
+++ b/template/en/default/global/useful-links.html.tmpl
@@ -72,10 +72,6 @@
     </li>
   [% END %]
 
-  [%# Individual bugs addition %]
-
-  [% PROCESS "global/per-bug-queries.html.tmpl" %]
-
   [%# Sections of links to more things users can do on this installation. %]
   [% Hook.process("end") %]
 </ul>