From: Thomas Graf <tgraf@suug.ch>
Date: Tue, 7 Nov 2006 14:34:27 +0000 (+0100)
Subject: [PKT_SCHED]: act_api: Fix module leak while flushing actions
X-Git-Tag: v2.6.16.32-rc1~26
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aa459cd3ef50097e5f6f3b659a0b28f740fd5c1c;p=thirdparty%2Fkernel%2Fstable.git

[PKT_SCHED]: act_api: Fix module leak while flushing actions

Module reference needs to be given back if message header
construction fails.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---

diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index eb7dc2947a0a2..a9fab455df08b 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -603,8 +603,8 @@ static int tca_action_flush(struct rtattr *rta, struct nlmsghdr *n, u32 pid)
 	return err;
 
 rtattr_failure:
-	module_put(a->ops->owner);
 nlmsg_failure:
+	module_put(a->ops->owner);
 err_out:
 	kfree_skb(skb);
 	kfree(a);