From: Victor Julien <victor@inliniac.net>
Date: Mon, 7 Oct 2019 11:09:02 +0000 (+0200)
Subject: detect/parser: minor cleanup
X-Git-Tag: suricata-5.0.0~53
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aa5a6ab5f1a4f146efbc11ab450488a26b6605c4;p=thirdparty%2Fsuricata.git

detect/parser: minor cleanup
---

diff --git a/src/detect-parse.c b/src/detect-parse.c
index 65e3b3564a..b910d0d761 100644
--- a/src/detect-parse.c
+++ b/src/detect-parse.c
@@ -703,6 +703,8 @@ static int SigParseOptions(DetectEngineCtx *de_ctx, Signature *s, char *optstr,
 #undef URL
     }
 
+    int setup_ret = 0;
+
     /* Validate double quoting, trimming trailing white space along the way. */
     if (optvalue != NULL && strlen(optvalue) > 0) {
         size_t ovlen = strlen(optvalue);
@@ -783,16 +785,14 @@ static int SigParseOptions(DetectEngineCtx *de_ctx, Signature *s, char *optstr,
             }
         }
         /* setup may or may not add a new SigMatch to the list */
-        if (st->Setup(de_ctx, s, ptr) < 0) {
-            SCLogDebug("\"%s\" failed to setup", st->name);
-            goto error;
-        }
+        setup_ret = st->Setup(de_ctx, s, ptr);
     } else {
         /* setup may or may not add a new SigMatch to the list */
-        if (st->Setup(de_ctx, s, NULL) < 0) {
-            SCLogDebug("\"%s\" failed to setup", st->name);
-            goto error;
-        }
+        setup_ret = st->Setup(de_ctx, s, NULL);
+    }
+    if (setup_ret < 0) {
+        SCLogDebug("\"%s\" failed to setup", st->name);
+        goto error;
     }
     s->init_data->negated = false;