From: Roger Dingledine <arma@torproject.org>
Date: Fri, 6 May 2016 13:55:06 +0000 (-0400)
Subject: stop looping once we know what the answer will be
X-Git-Tag: tor-0.2.8.3-alpha~16^2^2~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aa6341d4b9159e02825a03f1490ce6b731c2a90e;p=thirdparty%2Ftor.git

stop looping once we know what the answer will be

suggested during code review by dgoulet
---

diff --git a/src/or/networkstatus.c b/src/or/networkstatus.c
index 3d8bb55fc3..074922bcf0 100644
--- a/src/or/networkstatus.c
+++ b/src/or/networkstatus.c
@@ -1347,8 +1347,10 @@ networkstatus_consensus_is_already_downloading(const char *resource)
     connection_t *base = TO_CONN(dirconn);
     if (base->linked_conn &&
         base->linked_conn->type == CONN_TYPE_AP &&
-        !AP_CONN_STATE_IS_UNATTACHED(base->linked_conn->state))
+        !AP_CONN_STATE_IS_UNATTACHED(base->linked_conn->state)) {
       answer = 1;
+      break; /* stop looping, because we know the answer will be yes */
+    }
   } SMARTLIST_FOREACH_END(dirconn);
   smartlist_free(fetching_conns);