From: Ralf Wildenhues Date: Sun, 22 May 2011 17:02:27 +0000 (+0200) Subject: tests/README: fix example about `make -e' usage X-Git-Tag: v1.11.1b~26^2~31 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aa6883fdcf1e7f21ea81fe4745c0018a9398d43f;p=thirdparty%2Fautomake.git tests/README: fix example about `make -e' usage * tests/README (Section "Writing test cases" subsection "Do"): When some variable is never initialized in the Makefile, `-e' is not necessary in order to override it. DESTDIR is such a variable: we ensure that we do not ever initialize it. And as such, it is quite portable to use: $ make DESTDIR=/foo/bar install and in fact, quite widely used. So our example about when `make -e' is required, which references the `DESTDIR' variable, is poorly chosen, if not downright wrong. Rewrite it to use `prefix' as the overridden variable instead. --- diff --git a/ChangeLog b/ChangeLog index 363112927..583d3d4ee 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,18 @@ +2011-05-22 Ralf Wildenhues + Stefano Lattarini + + tests/README: fix example about `make -e' usage + * tests/README (Section "Writing test cases" subsection "Do"): When + some variable is never initialized in the Makefile, `-e' is not + necessary in order to override it. DESTDIR is such a variable: we + ensure that we do not ever initialize it. And as such, it is quite + portable to use: + $ make DESTDIR=/foo/bar install + and in fact, quite widely used. + So our example about when `make -e' is required, which references + the `DESTDIR' variable, is poorly chosen, if not downright wrong. + Rewrite it to use `prefix' as the overridden variable instead. + 2011-05-20 Stefano Lattarini testsuite: avoid re-running few tests with 'parallel-tests' option diff --git a/tests/README b/tests/README index 9680a5472..2b5b5afab 100644 --- a/tests/README +++ b/tests/README @@ -181,11 +181,11 @@ Do not here.) Do not override Makefile variables using make arguments, as in e.g.: - $MAKE DESTDIR=/foo/bar install + $MAKE prefix=/opt install This is not portable for recursive targets (targets that call a - sub-make may not pass `DESTDIR=/foo/bar' along). Use the following + sub-make may not pass `prefix=/opt' along). Use the following instead: - DESTDIR=/foo/bar $MAKE -e install + prefix=/opt $MAKE -e install Do not send a test case without signing a copyright disclaimer. See http://sources.redhat.com/automake/contribute.html or