From: Artem Boldariev <artem@boldariev.com>
Date: Wed, 26 Feb 2025 12:43:34 +0000 (+0200)
Subject: DoH: remove obsolete INSIST() check
X-Git-Tag: v9.18.35~7^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aa6fd85b0b141b5190580b7ceba18fcc50e30ab0;p=thirdparty%2Fbind9.git

DoH: remove obsolete INSIST() check

The check, while not active by default, is not valid since the commit
8b8f4d500d9c1d41d95d34a79c8935823978114c.

See 'if (total == 0) { ...' below branch to understand why.

(cherry picked from commit 217a1ebd79d90d2a3eebf44256fd15ab61a7d2a9)
---

diff --git a/lib/isc/netmgr/http.c b/lib/isc/netmgr/http.c
index 195d69851de..aac68ba667d 100644
--- a/lib/isc/netmgr/http.c
+++ b/lib/isc/netmgr/http.c
@@ -1506,8 +1506,6 @@ http_send_outgoing(isc_nm_http_session_t *session, isc_nmhandle_t *httphandle,
 		       (total == 0 && session->sending == 0) ||
 		       (total > 0 && session->sending == 0));
 	}
-#else
-	INSIST(ISC_LIST_EMPTY(session->pending_write_callbacks));
 #endif /* ENABLE_HTTP_WRITE_BUFFERING */
 
 	if (total == 0) {