From: Peter Krempa <pkrempa@redhat.com>
Date: Mon, 22 Mar 2021 16:38:24 +0000 (+0100)
Subject: virLogParseOutputs: Refactor string list handling
X-Git-Tag: v7.3.0-rc1~302
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aa8d253c1d78382c4b9a173efc4aad409e04a2b0;p=thirdparty%2Flibvirt.git

virLogParseOutputs: Refactor string list handling

Rewrite the code to remove the need to calculate the string list count.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/util/virlog.c b/src/util/virlog.c
index 004792db01..3fadf7fc4a 100644
--- a/src/util/virlog.c
+++ b/src/util/virlog.c
@@ -1612,22 +1612,22 @@ virLogParseOutputs(const char *src, virLogOutputPtr **outputs)
 {
     int at = -1;
     size_t noutputs = 0;
-    size_t i, count;
     g_auto(GStrv) strings = NULL;
+    GStrv next;
     virLogOutputPtr output = NULL;
     virLogOutputPtr *list = NULL;
 
     VIR_DEBUG("outputs=%s", src);
 
-    if (!(strings = virStringSplitCount(src, " ", 0, &count)))
+    if (!(strings = g_strsplit(src, " ", 0)))
         return -1;
 
-    for (i = 0; i < count; i++) {
-        /* virStringSplit may return empty strings */
-        if (STREQ(strings[i], ""))
+    for (next = strings; *next; next++) {
+        /* g_strsplit may return empty strings */
+        if (STREQ(*next, ""))
             continue;
 
-        if (!(output = virLogParseOutput(strings[i])))
+        if (!(output = virLogParseOutput(*next)))
             return -1;
 
         /* let's check if a duplicate output does not already exist in which