From: Thomas Veerman via Openvpn-devel <openvpn-devel@lists.sourceforge.net>
Date: Fri, 7 Jul 2017 19:59:41 +0000 (+0200)
Subject: Fix socks_proxy_port pointing to invalid data
X-Git-Tag: v2.5_beta1~611
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aa9d3a5bdc5a1b395d37fbb8abb3ed6166856a1a;p=thirdparty%2Fopenvpn.git

Fix socks_proxy_port pointing to invalid data

When setting the SOCKS proxy through the management interface, the
socks_proxy_port pointer would be set to a value that's no longer valid
by the time it's used by do_preresolve_host.

Signed-off-by: Thomas Veerman <thomas.veerman@wanwire.net>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <20170707195941.61773-1-thomas.veerman@wanwire.net>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15018.html
Signed-off-by: David Sommerseth <davids@openvpn.net>
---

diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index f0fc2418a..c61b06df0 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -150,7 +150,7 @@ management_callback_proxy_cmd(void *arg, const char **p)
         else if (streq(p[1], "SOCKS"))
         {
             ce->socks_proxy_server = string_alloc(p[2], gc);
-            ce->socks_proxy_port = p[3];
+            ce->socks_proxy_port = string_alloc(p[3], gc);
             ret = true;
         }
     }