From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Sun, 24 May 2020 16:52:58 +0000 (-0500)
Subject: value: missed return
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aab03ffc1250191d17b71007c9570eafdeef342b;p=thirdparty%2Ffreeradius-server.git

value: missed return
---

diff --git a/src/lib/util/value.c b/src/lib/util/value.c
index b9c9cb66585..86873310f5d 100644
--- a/src/lib/util/value.c
+++ b/src/lib/util/value.c
@@ -1857,7 +1857,7 @@ static inline int fr_value_box_cast_to_ipv4addr(TALLOC_CTX *ctx, fr_value_box_t
 	case FR_TYPE_STRING:
 		if (fr_value_box_from_str(ctx, dst, &dst_type, dst_enumv,
 				          src->vb_strvalue, src->datum.length, '\0', src->tainted) < 0) return -1;
-		break;
+		return 0;
 
 	default:
 		break;
@@ -1966,7 +1966,7 @@ static inline int fr_value_box_cast_to_ipv4prefix(TALLOC_CTX *ctx, fr_value_box_
 	case FR_TYPE_STRING:
 		if (fr_value_box_from_str(ctx, dst, &dst_type, dst_enumv,
 				          src->vb_strvalue, src->datum.length, '\0', src->tainted) < 0) return -1;
-		break;
+		return 0;
 
 	default:
 		break;
@@ -2078,7 +2078,7 @@ static inline int fr_value_box_cast_to_ipv6addr(TALLOC_CTX *ctx, fr_value_box_t
 	case FR_TYPE_STRING:
 		if (fr_value_box_from_str(ctx, dst, &dst_type, dst_enumv,
 				          src->vb_strvalue, src->datum.length, '\0', src->tainted) < 0) return -1;
-		break;
+		return 0;
 
 	default:
 		break;
@@ -2184,7 +2184,7 @@ static inline int fr_value_box_cast_to_ipv6prefix(TALLOC_CTX *ctx, fr_value_box_
 	case FR_TYPE_STRING:
 		if (fr_value_box_from_str(ctx, dst, &dst_type, dst_enumv,
 				          src->vb_strvalue, src->datum.length, '\0', src->tainted) < 0) return -1;
-		break;
+		return 0;
 
 	default:
 		break;