From: Štěpán Balážik <stepan.balazik@nic.cz>
Date: Fri, 22 Jan 2021 18:22:20 +0000 (+0100)
Subject: selection: only report RTT if there is an answer
X-Git-Tag: v5.3.0~15^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aab5be7b71f93e077ddb2cb6cc08595722b812cc;p=thirdparty%2Fknot-resolver.git

selection: only report RTT if there is an answer

Previously this would pollute the RTT cache with non-sensical
measurements from unsuccessful TCP connects for example.
---

diff --git a/daemon/worker.c b/daemon/worker.c
index 8f7382a4e..8a6d08b75 100644
--- a/daemon/worker.c
+++ b/daemon/worker.c
@@ -1599,7 +1599,7 @@ static int qr_task_step(struct qr_task *task,
 	}
 
 	// Report network RTT back to server selection
-	if (task->send_time && task->recv_time) {
+	if (packet && task->send_time && task->recv_time) {
 		struct kr_query *qry = array_tail(req->rplan.pending);
 		qry->server_selection.update_rtt(qry, task->transport, task->recv_time - task->send_time);
 	}