From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Tue, 9 Sep 2008 17:17:33 +0000 (-0600)
Subject: Do not erase the announcement port by assigning an accouncement IP address.
X-Git-Tag: SQUID_3_1_0_1~49^2~54
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aab975a80c573f24e8d2a4a800c6cf0a525e3430;p=thirdparty%2Fsquid.git

Do not erase the announcement port by assigning an accouncement IP address.

With 11(!) assignment operators (not even counting the implicit ones),
no wonder IPAddress assignment semantics gets lost on developers.
---

diff --git a/src/send-announce.cc b/src/send-announce.cc
index 2914fbf5a8..4d94c3b296 100644
--- a/src/send-announce.cc
+++ b/src/send-announce.cc
@@ -109,8 +109,8 @@ send_announce(const ipcache_addrs * ia, void *junk)
         }
     }
 
-    S.SetPort(port);
     S = ia->in_addrs[0];
+    S.SetPort(port);
     assert(theOutIcpConnection > 0);
     x = comm_udp_sendto(theOutIcpConnection, S, sndbuf, strlen(sndbuf) + 1);