From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Sat, 15 Apr 2017 18:28:16 +0000 (+0200)
Subject: auth: Clean up the conn check in GSQLBackend::reconnectIfNeeded()
X-Git-Tag: rec-4.1.0-alpha1~34^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aacd07ce0d579113e035f4387c5d5c53f50b3c9c;p=thirdparty%2Fpdns.git

auth: Clean up the conn check in GSQLBackend::reconnectIfNeeded()

We have a nice method, let's use it :)
---

diff --git a/pdns/backends/gsql/gsqlbackend.hh b/pdns/backends/gsql/gsqlbackend.hh
index 31224b6505..8fdb2393cf 100644
--- a/pdns/backends/gsql/gsqlbackend.hh
+++ b/pdns/backends/gsql/gsqlbackend.hh
@@ -252,10 +252,12 @@ protected:
   }
   virtual void reconnectIfNeeded()
   {
+    if (isConnectionUsable()) {
+      return;
+    }
+
     if (d_db) {
-      if(!d_db->isConnectionUsable()) {
-        d_db->reconnect();
-      }
+      d_db->reconnect();
     }
   }