From: mkanat%bugzilla.org <>
Date: Wed, 30 Sep 2009 08:59:50 +0000 (+0000)
Subject: Bug 511796: Allow groups to bless themselves
X-Git-Tag: bugzilla-3.5.1~49
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aadb30fd9cb9401d9f1ed9e82dbc02899851d11d;p=thirdparty%2Fbugzilla.git

Bug 511796: Allow groups to bless themselves
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit
---

diff --git a/editgroups.cgi b/editgroups.cgi
index 0554638faf..e8d8cfe24e 100755
--- a/editgroups.cgi
+++ b/editgroups.cgi
@@ -113,16 +113,19 @@ sub get_current_and_available {
                 if !grep($_->id == $group_option->id, @visible_to_me_current);
         }
 
-        # The group itself should never show up in the bless or 
-        # membership lists.
+        push(@bless_from_available, $group_option)
+            if !grep($_->id == $group_option->id, @bless_from_current);
+
+        # The group itself should never show up in the membership lists,
+        # and should show up in only one of the bless lists (otherwise
+        # you can try to allow it to bless itself twice, leading to a
+        # database unique constraint error).
         next if $group_option->id == $group->id;
 
         push(@members_available, $group_option)
             if !grep($_->id == $group_option->id, @members_current);
         push(@member_of_available, $group_option)
             if !grep($_->id == $group_option->id, @member_of_current);
-        push(@bless_from_available, $group_option)
-            if !grep($_->id == $group_option->id, @bless_from_current);
         push(@bless_to_available, $group_option)
            if !grep($_->id == $group_option->id, @bless_to_current);
     }