From: Henryk Plötz <henryk@ploetzli.ch>
Date: Thu, 9 Aug 2018 19:07:40 +0000 (+0200)
Subject: More DRY, less repeating
X-Git-Tag: v2.0.0~1^2~138
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aae31db26dacf1a41271beed89636985cbfd294f;p=thirdparty%2Fpython-fints.git

More DRY, less repeating
---

diff --git a/fints/segments/__init__.py b/fints/segments/__init__.py
index 8115db8..5d0ae96 100644
--- a/fints/segments/__init__.py
+++ b/fints/segments/__init__.py
@@ -133,22 +133,17 @@ class HISYN4(FinTS3Segment):
     security_reference_signature_key = DataElementField(type='num', max_length=16, required=False)
     security_reference_digital_signature = DataElementField(type='num', max_length=16, required=False)
 
-
-class HITANS1(FinTS3Segment):
+class ParameterSegment(FinTS3Segment):
     max_number_tasks = DataElementField(type='num', max_length=3)
     min_number_signatures = DataElementField(type='num', length=1)
     security_class = DataElementField(type='num', length=1)
-    parameters_twostep_tan = DataElementGroupField(type=ParameterTwostepTAN1)
 
-class HITANS3(FinTS3Segment):
-    max_number_tasks = DataElementField(type='num', max_length=3)
-    min_number_signatures = DataElementField(type='num', length=1)
-    security_class = DataElementField(type='num', length=1)
-    parameters_twostep_tan = DataElementGroupField(type=ParameterTwostepTAN3)
+class HITANS1(ParameterSegment):
+    parameters = DataElementGroupField(type=ParameterTwostepTAN1)
 
-class HIPINS1(FinTS3Segment):
-    max_number_tasks = DataElementField(type='num', max_length=3)
-    min_number_signatures = DataElementField(type='num', length=1)
-    security_class = DataElementField(type='num', length=1)
-    parameters_pintan = DataElementGroupField(type=ParameterPinTan)
+class HITANS3(ParameterSegment):
+    parameters = DataElementGroupField(type=ParameterTwostepTAN3)
+
+class HIPINS1(ParameterSegment):
+    parameters = DataElementGroupField(type=ParameterPinTan)