From: Simon McVittie <smcv@collabora.com>
Date: Fri, 15 Jul 2022 11:18:04 +0000 (+0100)
Subject: meson: Build with -fno-common if supported
X-Git-Tag: dbus-1.15.0~28^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ab01169a2046b8affefb8c984e284a4cd28039d4;p=thirdparty%2Fdbus.git

meson: Build with -fno-common if supported

This turns off a poorly-supported feature of older compilers. Even when
using an older compiler, we want to behave more strictly.

The Autotools build already did this.

Signed-off-by: Simon McVittie <smcv@collabora.com>
---

diff --git a/meson.build b/meson.build
index 765a5a33a..638bbf5fc 100644
--- a/meson.build
+++ b/meson.build
@@ -986,6 +986,11 @@ config.set_quoted('DBUS_EXEEXT', exe_ext)
 compile_warnings = []
 compile_warnings_c = []
 
+# -fno-common makes the linker more strict: on some systems the linker
+# is *always* this strict, so we want to behave like that everywhere.
+# We treat this like a warning, since that's basically how we're using it.
+compile_warnings += ['-fno-common']
+
 if cc.get_id() == 'msvc'
   compile_warnings += [
       # once