From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Tue, 21 May 2024 07:08:48 +0000 (+0200)
Subject: shared/btrfs-util: simplify return conditions
X-Git-Tag: v257-rc1~1191^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ab0137b44a4b0cf738381ef2109099dfd2f991a3;p=thirdparty%2Fsystemd.git

shared/btrfs-util: simplify return conditions

Coverity has trouble undertanding this function, so let's get rid of the
redundant return branch to simplify the code.
---

diff --git a/src/shared/btrfs-util.c b/src/shared/btrfs-util.c
index d6b218d842f..a7881b8b7e7 100644
--- a/src/shared/btrfs-util.c
+++ b/src/shared/btrfs-util.c
@@ -1637,13 +1637,10 @@ int btrfs_qgroup_find_parents(int fd, uint64_t qgroupid, uint64_t **ret) {
                         break;
         }
 
-        if (n_items <= 0) {
-                *ret = NULL;
-                return 0;
-        }
+        assert((n_items > 0) == !!items);
+        assert(n_items <= INT_MAX);
 
         *ret = TAKE_PTR(items);
-
         return (int) n_items;
 }