From: Alan T. DeKok Date: Thu, 19 Dec 2019 14:48:17 +0000 (-0500) Subject: check for Access-Reject, not Access-Accept. Found by PVS-Studio X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ab0a8d2185ca06997a72345b1828fdc3ebec4916;p=thirdparty%2Ffreeradius-server.git check for Access-Reject, not Access-Accept. Found by PVS-Studio --- diff --git a/src/modules/proto_radius/proto_radius_auth.c b/src/modules/proto_radius/proto_radius_auth.c index fe533f7e9c1..04f38d06570 100644 --- a/src/modules/proto_radius/proto_radius_auth.c +++ b/src/modules/proto_radius/proto_radius_auth.c @@ -654,7 +654,7 @@ static rlm_rcode_t mod_process(void const *instance, REQUEST *request) } else { auth_message(inst, request, true, "Login OK"); } - } else if (request->reply->code == FR_CODE_ACCESS_ACCEPT) { + } else if (request->reply->code == FR_CODE_ACCESS_REJECT) { vp = fr_pair_find_by_da(request->packet->vps, attr_module_failure_message, TAG_ANY); if (vp) { auth_message(inst, request, false, "Login incorrect (%pV)", &vp->data);