From: Max Kanat-Alexander <mkanat@bugzilla.org>
Date: Tue, 21 Dec 2010 23:55:01 +0000 (-0800)
Subject: Bug 620796: Make Bugzilla::Migrate skip abnormal fields when doing
X-Git-Tag: bugzilla-4.0rc2~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ab4a805e6383eda17096543c3291d281b8e3b545;p=thirdparty%2Fbugzilla.git

Bug 620796: Make Bugzilla::Migrate skip abnormal fields when doing
create_legal_values (otherwise it tried to create Components there, when
it should not have).
r=mkanat, a=mkanat (module owner)
---

diff --git a/Bugzilla/Migrate.pm b/Bugzilla/Migrate.pm
index e72c5c52e6..f28854957a 100644
--- a/Bugzilla/Migrate.pm
+++ b/Bugzilla/Migrate.pm
@@ -573,6 +573,7 @@ sub insert_users {
     }
 }
 
+# XXX This should also insert Classifications.
 sub insert_products {
     my ($self, $products) = @_;
     foreach my $product (@$products) {
@@ -639,6 +640,7 @@ sub create_legal_values {
     }
     
     foreach my $field (@select_fields) {
+        next if $field->is_abnormal;
         my $name = $field->name;
         foreach my $value (keys %{ $values{$name} }) {
             next if Bugzilla::Field::Choice->type($field)->new({ name => $value });