From: Amos Jeffries <squid3@treenet.co.nz>
Date: Fri, 2 Dec 2011 08:14:32 +0000 (-0700)
Subject: Bug 3433: Segfault closing SNMP
X-Git-Tag: SQUID_3_2_0_14~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ab4e451a58361c1bca42e636de4a5d01f910111f;p=thirdparty%2Fsquid.git

Bug 3433: Segfault closing SNMP
---

diff --git a/src/snmp_core.cc b/src/snmp_core.cc
index fd36968779..e5579529ac 100644
--- a/src/snmp_core.cc
+++ b/src/snmp_core.cc
@@ -358,13 +358,13 @@ snmpPortOpened(const Comm::ConnectionPointer &conn, int errNo)
 void
 snmpConnectionClose(void)
 {
-    if (!Comm::IsConnOpen(snmpIncomingConn)) {
+    if (Comm::IsConnOpen(snmpIncomingConn)) {
         debugs(49, DBG_IMPORTANT, "Closing SNMP receiving port " << snmpIncomingConn->local);
         snmpIncomingConn->close();
     }
     snmpIncomingConn = NULL;
 
-    if (!Comm::IsConnOpen(snmpOutgoingConn) && snmpIncomingConn != snmpOutgoingConn) {
+    if (Comm::IsConnOpen(snmpOutgoingConn) && snmpIncomingConn != snmpOutgoingConn) {
         // Perform OUT port closure so as not to step on IN port when sharing a conn.
         debugs(49, DBG_IMPORTANT, "Closing SNMP sending port " << snmpOutgoingConn->local);
         snmpOutgoingConn->close();