From: Andrew Bartlett <abartlet@samba.org>
Date: Wed, 20 Sep 2023 23:56:58 +0000 (+1200)
Subject: libcli/security: Check for sddl_from_conditional_ace() failure in test_sddl_condition... 
X-Git-Tag: tevent-0.16.0~411
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ab531abc52f9fff5d27f18861603d1ebfc963bd1;p=thirdparty%2Fsamba.git

libcli/security: Check for sddl_from_conditional_ace() failure in test_sddl_conditional_ace

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/libcli/security/tests/test_sddl_conditional_ace.c b/libcli/security/tests/test_sddl_conditional_ace.c
index cf487d09f25..479c0aa0527 100644
--- a/libcli/security/tests/test_sddl_conditional_ace.c
+++ b/libcli/security/tests/test_sddl_conditional_ace.c
@@ -660,7 +660,17 @@ static void test_round_trips(void **state)
 		}
 
 		resddl1 = sddl_from_conditional_ace(mem_ctx, s1);
+		if (resddl1 == NULL) {
+			failed = true;
+			debug_fail("could not re-make SDDL of %s\n", sddl[i]);
+			continue;
+		}
 		resddl2 = sddl_from_conditional_ace(mem_ctx, s2);
+		if (resddl2 == NULL) {
+			failed = true;
+			debug_fail("could not re-make SDDL of %s\n", sddl[i]);
+			continue;
+		}
 		if (strcmp(resddl1, resddl2) != 0) {
 			print_message("SDDL 2: %s\n", resddl2);
 			failed = failed || ok;