From: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Date: Tue, 14 Jun 2016 08:45:58 +0000 (+0300)
Subject: vz: dont remove domain from list on client object error
X-Git-Tag: v2.1.0-rc1~111
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ab64ebd1b52128555c430d59e53447cb670781d3;p=thirdparty%2Flibvirt.git

vz: dont remove domain from list on client object error

After domain is in the domains list let's keep it there. This
is approach taken by qemu driver and vz vzDomainMigrateFinish3Params too.
It quite reasonable, driver domain object is fully constructed and
can be discovered by client later.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
---

diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index 9a71c3b6a9..d7e768c0ec 100644
--- a/src/vz/vz_driver.c
+++ b/src/vz/vz_driver.c
@@ -791,12 +791,8 @@ vzDomainDefineXMLFlags(virConnectPtr conn, const char *xml, unsigned int flags)
  cleanup:
     if (olddom)
         virObjectUnlock(olddom);
-    if (newdom) {
-        if (!retdom)
-             virDomainObjListRemove(driver->domains, newdom);
-        else
-             virObjectUnlock(newdom);
-    }
+    if (newdom)
+        virObjectUnlock(newdom);
     virDomainDefFree(def);
     return retdom;
 }