From: lpsolit%gmail.com <>
Date: Thu, 29 Nov 2007 01:39:29 +0000 (+0000)
Subject: Bug 405404: HTML::Scrubber throws "undef error - Wide character in subroutine entry... 
X-Git-Tag: bugzilla-3.1.3~454
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ab73b625a7fb071794cd1152de3c8486d91788f6;p=thirdparty%2Fbugzilla.git

Bug 405404: HTML::Scrubber throws "undef error - Wide character in subroutine entry" when a field filtered with html_light contains UTF-8 characters - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
---

diff --git a/Bugzilla/Util.pm b/Bugzilla/Util.pm
index 144fb87c1a..40065c5c98 100644
--- a/Bugzilla/Util.pm
+++ b/Bugzilla/Util.pm
@@ -107,8 +107,7 @@ sub html_light_quote {
            require HTML::Parser;
     };
 
-    # We need utf8_mode() from HTML::Parser 3.40.
-    if ($@ || $HTML::Parser::VERSION < 3.40) { # Package(s) not installed.
+    if ($@) { # Package(s) not installed.
         my $safe = join('|', @allow);
         my $chr = chr(1);
 
@@ -172,12 +171,6 @@ sub html_light_quote {
                                            comment => 0,
                                            process => 0);
 
-        # Avoid filling the web server error log.
-        # In HTML::Scrubber 0.08, the HTML::Parser object is stored in
-        # the "_p" key, but this may change in future versions.
-        if (ref($scrubber->{_p}) eq 'HTML::Parser') {
-            $scrubber->{_p}->utf8_mode(1);
-        }
         return $scrubber->scrub($text);
     }
 }