From: Ivan Vecera <ivecera@redhat.com>
Date: Wed, 22 Oct 2025 12:23:02 +0000 (+0200)
Subject: devlink: fix devlink flash error reporting
X-Git-Tag: v6.18.0~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ab785eff0b1babfd826ce761f318bbdec6e60d90;p=thirdparty%2Fiproute2.git

devlink: fix devlink flash error reporting

Currently, devlink silently exits when a non-existent device is specified
for flashing or when the user lacks sufficient permissions. This makes it
hard to diagnose the problem.

Print an appropriate error message in these cases to improve user feedback.

Prior:
$ devlink dev flash foo/bar file test
$ sudo devlink dev flash foo/bar file test
$

After patch:
$ devlink/devlink dev flash foo/bar file test
devlink answers: Operation not permitted
$ sudo devlink/devlink dev flash foo/bar file test
devlink answers: No such device

Fixes: 9b13cddfe268 ("devlink: implement flash status monitoring")
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---

diff --git a/devlink/devlink.c b/devlink/devlink.c
index 171b8532..b162cf40 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -4594,6 +4594,8 @@ static int cmd_dev_flash(struct dl *dl)
 	} while (!ctx.flash_done || (ctx.not_first && !ctx.received_end));
 
 	err = mnlu_gen_socket_recv_run(&dl->nlg, NULL, NULL);
+	if (err < 0)
+		pr_err("devlink answers: %s\n", strerror(errno));
 
 out:
 	close(pipe_r);