From: Pavel Hrdina <phrdina@redhat.com>
Date: Mon, 13 Jan 2014 15:50:00 +0000 (+0100)
Subject: Fix coverity complain in commandtest.c
X-Git-Tag: CVE-2014-0028~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ab8692b639011547eef8be209c94bba2300fd1a9;p=thirdparty%2Flibvirt.git

Fix coverity complain in commandtest.c

For a "newfd1" the coverity tools thinks that the fd is closed in
a "virCommandPassFD", but with "flags == 0" it cannot be closed.

The code itself is ok, but coverity tool thinks that there is
"double_close" of the "newfd1" and to prevent showing this error
we simply add a comment before the proper close.

This has been found by coverity.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---

diff --git a/tests/commandtest.c b/tests/commandtest.c
index 08e9e21fc6..7ff4d5fc59 100644
--- a/tests/commandtest.c
+++ b/tests/commandtest.c
@@ -215,6 +215,7 @@ static int test3(const void *unused ATTRIBUTE_UNUSED)
 
 cleanup:
     virCommandFree(cmd);
+    /* coverity[double_close] */
     VIR_FORCE_CLOSE(newfd1);
     VIR_FORCE_CLOSE(newfd2);
     return ret;