From: Evan You <yyx990803@gmail.com>
Date: Tue, 27 Sep 2022 07:50:26 +0000 (+0800)
Subject: chore: remove no longer used cloneNode implementation in nodeOps
X-Git-Tag: v3.2.40~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ab8bfac0a1d2c97cd653b736065a960eb2eaf354;p=thirdparty%2Fvuejs%2Fcore.git

chore: remove no longer used cloneNode implementation in nodeOps
---

diff --git a/packages/runtime-dom/__tests__/nodeOps.spec.ts b/packages/runtime-dom/__tests__/nodeOps.spec.ts
index dcab9a0a6b..2573974c95 100644
--- a/packages/runtime-dom/__tests__/nodeOps.spec.ts
+++ b/packages/runtime-dom/__tests__/nodeOps.spec.ts
@@ -1,15 +1,6 @@
 import { nodeOps, svgNS } from '../src/nodeOps'
 
 describe('runtime-dom: node-ops', () => {
-  test('the _value property should be cloned', () => {
-    const el = nodeOps.createElement('input') as HTMLDivElement & {
-      _value: any
-    }
-    el._value = 1
-    const cloned = nodeOps.cloneNode!(el) as HTMLDivElement & { _value: any }
-    expect(cloned._value).toBe(1)
-  })
-
   test("the <select>'s multiple attr should be set in createElement", () => {
     const el = nodeOps.createElement('select', false, undefined, {
       multiple: ''
diff --git a/packages/runtime-dom/src/nodeOps.ts b/packages/runtime-dom/src/nodeOps.ts
index c03bda4e31..daf56fc6f3 100644
--- a/packages/runtime-dom/src/nodeOps.ts
+++ b/packages/runtime-dom/src/nodeOps.ts
@@ -52,23 +52,6 @@ export const nodeOps: Omit<RendererOptions<Node, Element>, 'patchProp'> = {
     el.setAttribute(id, '')
   },
 
-  cloneNode(el) {
-    const cloned = el.cloneNode(true)
-    // #3072
-    // - in `patchDOMProp`, we store the actual value in the `el._value` property.
-    // - normally, elements using `:value` bindings will not be hoisted, but if
-    //   the bound value is a constant, e.g. `:value="true"` - they do get
-    //   hoisted.
-    // - in production, hoisted nodes are cloned when subsequent inserts, but
-    //   cloneNode() does not copy the custom property we attached.
-    // - This may need to account for other custom DOM properties we attach to
-    //   elements in addition to `_value` in the future.
-    if (`_value` in el) {
-      ;(cloned as any)._value = (el as any)._value
-    }
-    return cloned
-  },
-
   // __UNSAFE__
   // Reason: innerHTML.
   // Static content here can only come from compiled templates.