From: Stefan Liebler Date: Mon, 20 Jan 2020 09:55:55 +0000 (+0100) Subject: Get rid of Werror=maybe-uninitialized in res_send.c. X-Git-Tag: glibc-2.31~18 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=aba12794dc0d1835b9652f34df722970b1bd3397;p=thirdparty%2Fglibc.git Get rid of Werror=maybe-uninitialized in res_send.c. The commit 446997ff1433d33452b81dfa9e626b8dccf101a4 introduced this new usage of resplen. If build with gcc 9 -march>=z13 on s390x, the following warning occurs: res_send.c: In function ‘__res_context_send’: res_send.c:539:6: error: ‘resplen’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 539 | if (resplen > HFIXEDSZ) | ^ Therefore this patch adds a further DIAG_IGNORE_NEEDS_COMMENT in the same way as it was previously done for usages of resplen or n. See commit d1bc2cbbed9aea2017ef941f63c8786571da5b4f. --- diff --git a/resolv/res_send.c b/resolv/res_send.c index 89c40ce0137..7e5fec66466 100644 --- a/resolv/res_send.c +++ b/resolv/res_send.c @@ -534,6 +534,9 @@ __res_context_send (struct resolv_context *ctx, resplen = n; + /* See comment at the declaration of n. Note: resplen = n; */ + DIAG_PUSH_NEEDS_COMMENT; + DIAG_IGNORE_NEEDS_COMMENT (9, "-Wmaybe-uninitialized"); /* Mask the AD bit in both responses unless it is marked trusted. */ if (resplen > HFIXEDSZ) @@ -543,6 +546,7 @@ __res_context_send (struct resolv_context *ctx, else mask_ad_bit (ctx, ans); } + DIAG_POP_NEEDS_COMMENT; if (resplen2 != NULL && *resplen2 > HFIXEDSZ) mask_ad_bit (ctx, *ansp2);