From: Martin Willi <martin@revosec.ch>
Date: Thu, 6 Feb 2014 15:38:39 +0000 (+0100)
Subject: updown: Return an empty DNS server enumerator if no IKE_SA available
X-Git-Tag: 5.1.2rc1~26
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ac2dc3b726b43910c2b8dd1d13c62a76315ccd23;p=thirdparty%2Fstrongswan.git

updown: Return an empty DNS server enumerator if no IKE_SA available

The one existing caller does not handle a NULL return and always expects
an enumerator; and returning FALSE does not make sense anyway.
---

diff --git a/src/libcharon/plugins/updown/updown_handler.c b/src/libcharon/plugins/updown/updown_handler.c
index 3a644380a2..0894d2d074 100644
--- a/src/libcharon/plugins/updown/updown_handler.c
+++ b/src/libcharon/plugins/updown/updown_handler.c
@@ -188,7 +188,7 @@ METHOD(updown_handler_t, create_dns_enumerator, enumerator_t*,
 	ike_sa = charon->bus->get_sa(charon->bus);
 	if (!ike_sa)
 	{
-		return FALSE;
+		return enumerator_create_empty();
 	}
 
 	this->lock->read_lock(this->lock);