From: Francis Dupont Date: Tue, 4 Aug 2026 17:29:59 +0000 (+0200) Subject: [#4636] Style X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ac3ad23a77f3eef12f6ea484a4ceb6b90ef35962;p=thirdparty%2Fkea.git [#4636] Style --- diff --git a/src/lib/cc/tests/data_unittests.cc b/src/lib/cc/tests/data_unittests.cc index 57d7405c19..2d896eca14 100644 --- a/src/lib/cc/tests/data_unittests.cc +++ b/src/lib/cc/tests/data_unittests.cc @@ -751,21 +751,21 @@ TEST(Element, listElement) { // rather than invoking undefined behavior (Gitlab #4636). TEST(Element, listElementRemoveOutOfRange) { ElementPtr el = Element::fromJSON("[ 1, 2 ]"); - ASSERT_EQ(2, static_cast(el->size())); + ASSERT_EQ(2U, el->size()); // Index past the end should be a no-op. EXPECT_NO_THROW(el->remove(5)); - EXPECT_EQ(2, static_cast(el->size())); + EXPECT_EQ(2U, el->size()); EXPECT_EQ("[ 1, 2 ]", el->str()); // Index equal to size should be a no-op. EXPECT_NO_THROW(el->remove(2)); - EXPECT_EQ(2, static_cast(el->size())); + EXPECT_EQ(2U, el->size()); EXPECT_EQ("[ 1, 2 ]", el->str()); // Negative index should be a no-op. EXPECT_NO_THROW(el->remove(-1)); - EXPECT_EQ(2, static_cast(el->size())); + EXPECT_EQ(2U, el->size()); EXPECT_EQ("[ 1, 2 ]", el->str()); // Empty list: any remove should be a no-op. @@ -775,7 +775,7 @@ TEST(Element, listElementRemoveOutOfRange) { // In-range remove still works. EXPECT_NO_THROW(el->remove(0)); - EXPECT_EQ(1, static_cast(el->size())); + EXPECT_EQ(1U, el->size()); EXPECT_EQ(2, el->get(0)->intValue()); }