From: Tobias Burnus <burnus@net-b.de>
Date: Sun, 6 Jan 2008 19:36:44 +0000 (+0100)
Subject: re PR fortran/34689 (libgomp.fortran/appendix-a/a.33.3.f90  -O  (test for excess... 
X-Git-Tag: releases/gcc-4.3.0~725
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ac61ba6af2767152007278e0b1637d1447ca93a7;p=thirdparty%2Fgcc.git

re PR fortran/34689 (libgomp.fortran/appendix-a/a.33.3.f90  -O  (test for excess errors))

2008-01-06  Tobias Burnus  <burnus@net-b.de>

       PR fortran/34689
       * interface.c (compare_actual_formal): Fix intent(out) check for
       function result variables.

2008-01-06  Tobias Burnus  <burnus@net-b.de>

       PR fortran/34689
       * gfortran.dg/intent_out_4.f90: New.

From-SVN: r131359
---

diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog
index 932527eadf8f..09155e3f26a9 100644
--- a/gcc/fortran/ChangeLog
+++ b/gcc/fortran/ChangeLog
@@ -1,3 +1,9 @@
+2008-01-06  Tobias Burnus  <burnus@net-b.de>
+
+	PR fortran/34689
+	* interface.c (compare_actual_formal): Fix intent(out) check for
+	function result variables.
+
 2008-01-06  Jerry DeLisle  <jvdelisle@gcc.gnu.org>
 
 	PR fortran/34387
diff --git a/gcc/fortran/interface.c b/gcc/fortran/interface.c
index b900b102fe5e..8088fc654321 100644
--- a/gcc/fortran/interface.c
+++ b/gcc/fortran/interface.c
@@ -1909,7 +1909,8 @@ compare_actual_formal (gfc_actual_arglist **ap, gfc_formal_arglist *formal,
 
       /* Check intent = OUT/INOUT for definable actual argument.  */
       if ((a->expr->expr_type != EXPR_VARIABLE
-	   || a->expr->symtree->n.sym->attr.flavor != FL_VARIABLE)
+	   || (a->expr->symtree->n.sym->attr.flavor != FL_VARIABLE
+	       && a->expr->symtree->n.sym->attr.flavor != FL_PROCEDURE))
 	  && (f->sym->attr.intent == INTENT_OUT
 	      || f->sym->attr.intent == INTENT_INOUT))
 	{
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index e0c426684d10..1631fe900214 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2008-01-06  Tobias Burnus  <burnus@net-b.de>
+
+	PR fortran/34689
+	* gfortran.dg/intent_out_4.f90: New.
+
 2008-01-06  Jerry DeLisle  <jvdelisle@gcc.gnu.org>
 
 	PR libfortran/34540
diff --git a/gcc/testsuite/gfortran.dg/intent_out_4.f90 b/gcc/testsuite/gfortran.dg/intent_out_4.f90
new file mode 100644
index 000000000000..e34c452e8e6a
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/intent_out_4.f90
@@ -0,0 +1,18 @@
+! { dg-do compile }
+!
+! PR fortran/34689
+!
+! The following (cf. libgomp.fortran/appendix-a/a.33.3.f90)
+! was rejected because the intent check missed a FL_FUNCTION
+! for the result variable.
+!
+function test()
+  implicit none
+  integer :: test
+  interface
+    subroutine foo(a)
+      integer(inout) :: a
+    end subroutine foo
+  end interface
+  call foo(a)
+end function test