From: Jeff Lucovsky <jeff@lucovsky.org>
Date: Fri, 10 Jul 2020 12:19:51 +0000 (-0400)
Subject: filestore: Correct Coverity RESOURCE_LEAK issue
X-Git-Tag: suricata-6.0.0-beta1~226
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ac70d925f540800fdf03b07ca7114174f1fceebf;p=thirdparty%2Fsuricata.git

filestore: Correct Coverity RESOURCE_LEAK issue

This commit corrects the RESOURCE_LEAK issue (CID 1465222) of the `FILE`
pointer.
---

diff --git a/src/output-filestore.c b/src/output-filestore.c
index cc34421a0f..bf2abf1d15 100644
--- a/src/output-filestore.c
+++ b/src/output-filestore.c
@@ -177,6 +177,7 @@ static void OutputFilestoreFinalizeFiles(ThreadVars *tv,
                 if (out != NULL) {
                     size_t js_len = jb_len(js_fileinfo);
                     fwrite(jb_ptr(js_fileinfo), js_len, 1, out);
+                    fclose(out);
                 }
                 jb_free(js_fileinfo);
             }