From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Thu, 25 May 2017 22:11:51 +0000 (-0400)
Subject: Use normal return codes
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ac89aa0cb513992bfa0f95d819909a4606c825de;p=thirdparty%2Ffreeradius-server.git

Use normal return codes
---

diff --git a/src/modules/rlm_eap/types/rlm_eap_peap/peap.c b/src/modules/rlm_eap/types/rlm_eap_peap/peap.c
index 77cd40959ed..90c19809670 100644
--- a/src/modules/rlm_eap/types/rlm_eap_peap/peap.c
+++ b/src/modules/rlm_eap/types/rlm_eap_peap/peap.c
@@ -242,7 +242,7 @@ static int eap_peap_verify(REQUEST *request, peap_tunnel_t *peap_tunnel,
 	switch (eap_method) {
 	case FR_EAP_IDENTITY:
 		RDEBUG2("Received EAP-Identity-Response");
-		return 1;
+		return 0;
 
 	/*
 	 *	We normally do Microsoft MS-CHAPv2 (26), versus
@@ -251,7 +251,7 @@ static int eap_peap_verify(REQUEST *request, peap_tunnel_t *peap_tunnel,
 	case FR_EAP_MSCHAPV2:
 	default:
 		RDEBUG2("EAP method %s (%d)", eap_type2name(eap_method), eap_method);
-		return 1;
+		return 0;
 	}
 
 }
@@ -640,8 +640,7 @@ rlm_rcode_t eap_peap_process(eap_session_t *eap_session, tls_session_t *tls_sess
 
 	RDEBUG2("PEAP state %s", peap_state(t));
 
-	if ((t->status != PEAP_STATUS_TUNNEL_ESTABLISHED) &&
-	    !eap_peap_verify(request, t, data, data_len)) {
+	if ((t->status != PEAP_STATUS_TUNNEL_ESTABLISHED) && (eap_peap_verify(request, t, data, data_len) < 0)) {
 		REDEBUG("Tunneled data is invalid");
 		return RLM_MODULE_REJECT;
 	}