From: Steffan Karger Date: Sun, 8 Nov 2015 12:04:27 +0000 (+0100) Subject: Fix unintialized variable in plugin_vlog() X-Git-Tag: v2.3.9~28 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=acc74694293b85dd9d8ef129c068b8ce5058dee1;p=thirdparty%2Fopenvpn.git Fix unintialized variable in plugin_vlog() Does not seem to be a problem in normal usage, because one of the PLOG_ERR, PLOG_WARN, PLOG_NOTE or PLOG_DEBUG will be set, and will cause msg_flags to be initialized. In the worst case, msg_flags might accidentally end up having M_FATAL set, causing openvpn to exit. This was previously fixed in the master branch (5ead2ae0), but was not backported to release/2.3, probably because that commit fixed other parts of the code too, and those parts are quite different between master and release/2.3. Re-discovered by coverity. Signed-off-by: Steffan Karger Acked-by: Gert Doering Message-Id: <1446984267-3323-1-git-send-email-steffan@karger.me> URL: http://article.gmane.org/gmane.network.openvpn.devel/10450 Signed-off-by: Gert Doering --- diff --git a/src/openvpn/plugin.c b/src/openvpn/plugin.c index 0948f2385..54c5b52d6 100644 --- a/src/openvpn/plugin.c +++ b/src/openvpn/plugin.c @@ -291,7 +291,7 @@ plugin_init_item (struct plugin *p, const struct plugin_option *o) static void plugin_vlog (openvpn_plugin_log_flags_t flags, const char *name, const char *format, va_list arglist) { - unsigned int msg_flags; + unsigned int msg_flags = 0; if (!format) return;