From: Stéphane Graber <stgraber@ubuntu.com>
Date: Fri, 14 Feb 2014 21:06:17 +0000 (-0500)
Subject: coverity: Check return value of setenv
X-Git-Tag: lxc-1.0.0.rc2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=acd4922efe82a3b9d83eb231cd227fc322be8363;p=thirdparty%2Flxc.git

coverity: Check return value of setenv

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
---

diff --git a/src/lxc/attach.c b/src/lxc/attach.c
index 87826522d..28cf91635 100644
--- a/src/lxc/attach.c
+++ b/src/lxc/attach.c
@@ -317,8 +317,10 @@ static int lxc_attach_set_environment(enum lxc_attach_env_policy_t policy, char*
 		if (extra_keep_store) {
 			size_t i;
 			for (i = 0; extra_keep[i]; i++) {
-				if (extra_keep_store[i])
-					setenv(extra_keep[i], extra_keep_store[i], 1);
+				if (extra_keep_store[i]) {
+					if (setenv(extra_keep[i], extra_keep_store[i], 1) < 0)
+						SYSERROR("Unable to set environment variable");
+				}
 				free(extra_keep_store[i]);
 			}
 			free(extra_keep_store);