From: Peter Krempa <pkrempa@redhat.com>
Date: Wed, 6 Oct 2021 11:11:10 +0000 (+0200)
Subject: virJSONValueObjectAddVArgs: Add check for presence of the ':' separator
X-Git-Tag: v7.9.0-rc1~230
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=acf4159556f6b456d368ea2a4c2991fd4a35f757;p=thirdparty%2Flibvirt.git

virJSONValueObjectAddVArgs: Add check for presence of the ':' separator

Enforce that the ':' separator between the key and value is always
present.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/util/virjson.c b/src/util/virjson.c
index 26491bd6c7..4aabad15ef 100644
--- a/src/util/virjson.c
+++ b/src/util/virjson.c
@@ -161,9 +161,9 @@ virJSONValueObjectAddVArgs(virJSONValue *obj,
 
     while ((key = va_arg(args, char *)) != NULL) {
 
-        if (strlen(key) < 3) {
+        if (strlen(key) < 3 || key[1] != ':') {
             virReportError(VIR_ERR_INTERNAL_ERROR,
-                           _("argument key '%s' is too short, missing type prefix"),
+                           _("argument key '%s' is too short or malformed"),
                            key);
             return -1;
         }