From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Sat, 23 Apr 2022 01:18:41 +0000 (-0500)
Subject: Just use fopen...
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ad05cd92731f0456c88356d4044b062f8ba5be1e;p=thirdparty%2Ffreeradius-server.git

Just use fopen...
---

diff --git a/src/lib/server/main_config.c b/src/lib/server/main_config.c
index e5752d8b60e..192f8e4eeff 100644
--- a/src/lib/server/main_config.c
+++ b/src/lib/server/main_config.c
@@ -857,15 +857,15 @@ int main_config_exclusive_proc(main_config_t *config)
 	char *path;
 	int sem_id;
 	int ret;
-	int fd = -1;
+	FILE *fp = NULL;
 	static bool sem_initd;
 
 	if (unlikely(sem_initd)) return 0;
 
 	if (config->write_pid) {
 		fr_assert(config->pid_file);
-		fd = open(config->pid_file, O_CREAT | O_CLOEXEC);	/* May not have been created yet */
-		if (fd < 0) {
+		fp = fopen(config->pid_file, "w");
+		if (!fp) {
 			fr_strerror_printf("Refusing to start - Failed creating PID file at \"%s\" - %s",
 					   config->pid_file, fr_syserror(errno));
 			return -1;
@@ -909,7 +909,7 @@ int main_config_exclusive_proc(main_config_t *config)
 		break;
 	}
 
-	if (fd != -1) close(fd);
+	if (fp != NULL) fclose(fp);
 
 	return ret;
 }