From: Andres Avila Segura (aavilase) <aavilase@cisco.com>
Date: Mon, 3 Nov 2025 15:39:50 +0000 (+0000)
Subject: Pull request #4967: appid: suppress false positive coverity warning
X-Git-Tag: 3.9.7.0~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ad67756209c07fb129602bdd28f9b2c574f47c0d;p=thirdparty%2Fsnort3.git

Pull request #4967: appid: suppress false positive coverity warning

Merge in SNORT/snort3 from ~AAVILASE/snort3:suppress_coverity_warning to master

Squashed commit of the following:

commit 3f45980bf43e944f4eddc181965360fb3671102d
Author: Andres Avila <aavilase@cisco.com>
Date:   Thu Oct 30 11:04:40 2025 -0400

    appid: suppress false positive coverity warning
---

diff --git a/src/network_inspectors/appid/service_plugins/service_ftp.cc b/src/network_inspectors/appid/service_plugins/service_ftp.cc
index d72fddbd8..0dd9b6e4d 100644
--- a/src/network_inspectors/appid/service_plugins/service_ftp.cc
+++ b/src/network_inspectors/appid/service_plugins/service_ftp.cc
@@ -151,6 +151,7 @@ static inline void CopyVersionString(ServiceFTPData& fd, const uint8_t* version,
     {
         copyLen--;
     }
+    // coverity[integer_overflow]
     if (copyLen > 0)
         memcpy(fd.version, version, copyLen);
     fd.version[copyLen] = '\0';