From: Tobias Stoeckmann <tobias@stoeckmann.org>
Date: Sun, 22 Dec 2024 16:24:57 +0000 (+0100)
Subject: lsmod: Simplify code
X-Git-Tag: v34~24
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ad689ac6b7d3873e7239b9e78e7a768bdf63e397;p=thirdparty%2Fkmod.git

lsmod: Simplify code

Reduces cyclomatic complexity and binary size.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
Link: https://github.com/kmod-project/kmod/pull/271
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
---

diff --git a/tools/lsmod.c b/tools/lsmod.c
index ef5a08c9..ea68d1dc 100644
--- a/tools/lsmod.c
+++ b/tools/lsmod.c
@@ -101,19 +101,15 @@ static int do_lsmod(int argc, char *argv[])
 		int use_count = kmod_module_get_refcnt(mod);
 		long size = kmod_module_get_size(mod);
 		struct kmod_list *holders, *hitr;
-		int first = 1;
+		int sep = ' ';
 
 		printf("%-19s %8ld  %d", name, size, use_count);
 		holders = kmod_module_get_holders(mod);
 		kmod_list_foreach(hitr, holders) {
 			struct kmod_module *hm = kmod_module_get_module(hitr);
 
-			if (!first) {
-				putchar(',');
-			} else {
-				putchar(' ');
-				first = 0;
-			}
+			putchar(sep);
+			sep = ',';
 
 			fputs(kmod_module_get_name(hm), stdout);
 			kmod_module_unref(hm);