From: Christopher Faulet <cfaulet@haproxy.com>
Date: Tue, 10 Sep 2019 08:01:26 +0000 (+0200)
Subject: BUG/MINOR: listener: Fix a possible null pointer dereference
X-Git-Tag: v2.1-dev2~90
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ad6c2eac28ed96ec8e8c90bd5ce68794ea6bf000;p=thirdparty%2Fhaproxy.git

BUG/MINOR: listener: Fix a possible null pointer dereference

It seems to be possible to have no frontend for a listener. A test was missing
before dereferencing it at the end of the function listener_accept().

This patch fixes the issue #264. It must be backported to 2.0 and 1.9.
---

diff --git a/src/listener.c b/src/listener.c
index 54c0996021..33ac6ce119 100644
--- a/src/listener.c
+++ b/src/listener.c
@@ -1065,7 +1065,7 @@ void listener_accept(int fd)
 		if (!LIST_ISEMPTY(&global_listener_queue))
 			dequeue_all_listeners(&global_listener_queue);
 
-		if (!LIST_ISEMPTY(&p->listener_queue) &&
+		if (p && !LIST_ISEMPTY(&p->listener_queue) &&
 		    (!p->fe_sps_lim || freq_ctr_remain(&p->fe_sess_per_sec, p->fe_sps_lim, 0) > 0))
 			dequeue_all_listeners(&p->listener_queue);
 	}